Change in ovirt-engine[master]: webadmin: AddRemoveRowWidget to enable/disable rows

lvernia at redhat.com lvernia at redhat.com
Thu Jul 10 11:46:43 UTC 2014


Lior Vernia has submitted this change and it was merged.

Change subject: webadmin: AddRemoveRowWidget to enable/disable rows
......................................................................


webadmin: AddRemoveRowWidget to enable/disable rows

Added the ability for AddRemoveRowWidget to change whether individual
rows are enabled/disabled according to the underlying model's
changeability.

This obviated the corresponding implementation in KeyValueWidget
(which will now benefit from AddRemoveRowWidget's capabilities by
extending it), and in various other places where this behavior had to
be implemented manually.

Change-Id: Ia9a6265b5c0eb27c3b99b98d88986762249acdbe
Signed-off-by: Lior Vernia <lvernia at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmPopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/scheduling/NewClusterPolicyModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/profile/VnicProfilePopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksInterfacePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/profile/VnicProfilePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyPopupView.java
10 files changed, 57 insertions(+), 56 deletions(-)

Approvals:
  Lior Vernia: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/29228
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia9a6265b5c0eb27c3b99b98d88986762249acdbe
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list