Change in ovirt-engine[master]: core: Remove static member initialization from a config value

[tnisan at redhat.com]

Tal Nisan has submitted this change and it was merged.

Change subject: core: Remove static member initialization from a config value
......................................................................


core: Remove static member initialization from a config value

Removed static member initialization from a config value in
InitVdsOnUpCommand, initialization of static member from config, database
and such prevent the possibility to initialize a class instance without
mocking the corresponding environments and is considered bad practice

Change-Id: Ifb76820c331ef0e4f5cd53b5c12c52989e50c4dc
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
1 file changed, 10 insertions(+), 3 deletions(-)

Approvals:
  Tal Nisan: Verified
  Allon Mureinik: Looks good to me, approved
  Omer Frenkel: Looks good to me, but someone else must approve
  Yair Zaslavsky: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/29778
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb76820c331ef0e4f5cd53b5c12c52989e50c4dc
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server