Change in ovirt-engine[ovirt-engine-3.5]: core:Class cast exception when fence fails

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Tue Jul 22 10:57:44 UTC 2014


Piotr Kliczewski has submitted this change and it was merged.

Change subject: core:Class cast exception when fence fails
......................................................................


core:Class cast exception when fence fails

The problem was that in the case that the proxy host is blocked by
iptables to access the PM card we got a message result in the RPC XML
return value which is Object[].
In the code, there was attempt to cast this result to a string which
obviously failed with ClassCastException.
This patch adds check for the message type and gets it properly as
string in the case that we got Object[].

Change-Id: I511599ce3c6dbf313cbe8d1f0f57e329a4aa1d79
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1114977
Signed-off-by: Eli Mesika <emesika at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/StatusForXmlRpc.java
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  Eli Mesika: Verified
  Yair Zaslavsky: Looks good to me, approved
  Oved Ourfali: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/30570
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I511599ce3c6dbf313cbe8d1f0f57e329a4aa1d79
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list