Change in ovirt-engine[master]: core: custom fencing settings are not save to DB

oourfali at redhat.com oourfali at redhat.com
Wed Jul 23 13:44:59 UTC 2014


Oved Ourfali has submitted this change and it was merged.

Change subject: core: custom fencing settings are  not save to DB
......................................................................


core: custom fencing settings are  not save to DB

3.5 version introduced a new way to define custom fencing agents.
However, there is a bug that caused custom PM agent settings not to be
saved in DB.
The UpdateVdsCommand canDoAction checks for validity of the agent and it
comapres the selected agent against all of agents supported natively by
the agent.
The code was changed to take into account custom PM agents as well in
the canDoAction validation

Change-Id: If41fb226cbb3a80aa2a524e22756a91553dec1b1
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1122473
Signed-off-by: Eli Mesika <emesika at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java
1 file changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Martin Peřina: Looks good to me, but someone else must approve
  Eli Mesika: Verified
  Oved Ourfali: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/30643
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If41fb226cbb3a80aa2a524e22756a91553dec1b1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list