Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Wrong vnics when creating vm from blank template

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Thu Jul 24 12:55:04 UTC 2014


Piotr Kliczewski has submitted this change and it was merged.

Change subject: webadmin: Wrong vnics when creating vm from blank template
......................................................................


webadmin: Wrong vnics when creating vm from blank template

The 'Blank' template belongs to the 'Default' dc/cluster.
If the 'Blank' template has vnics with profiles, when creating a vm in
different cluster than 'Default' the vnic profiles (which don't exist in
the vm's cluster) should be overridden by 'Empty' profile.

This override happens in EditProfileBehavior->initSelectedProfile, but
since it is called before the registration of ProfileInstanceTypeEditor
to SelectedItemChangedEvent of VnicInstanceType the new selection of
'Empty' profile isn't reflected on VnicInstanceType.NetworkInterface.

This patch fixes it by calling syncSelectedItemWithNetworkInterface(..)
also before the registration and not just from the eventRaised(..).

Change-Id: I60be6b21050c43bb004e56688f8e306b5b943d24
Bug-Url: https://bugzilla.redhat.com/1103058
Signed-off-by: Alona Kaplan <alkaplan at redhat.com>
(cherry picked from commit c57055367478087dbdb3602671f8331b747bd9df)
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.java
1 file changed, 10 insertions(+), 7 deletions(-)

Approvals:
  Alona Kaplan: Verified
  Lior Vernia: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/30668
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I60be6b21050c43bb004e56688f8e306b5b943d24
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list