Change in ovirt-engine[ovirt-engine-3.5]: core: fix race when removing memory volumes during Live Merge

oourfali at redhat.com oourfali at redhat.com
Sun Jul 27 07:18:01 UTC 2014


Oved Ourfali has submitted this change and it was merged.

Change subject: core: fix race when removing memory volumes during Live Merge
......................................................................


core: fix race when removing memory volumes during Live Merge

Memory volume removal was not tracked as a child command, and its
completion would trigger endAction of RemoveSnapshotCommand before the
tasks run by ExecutionHandler were complete.  Instead, use the newer
RemoveMemoryVolumesCommand during Live Merge, which Executionhandler can
coordinate.

Change-Id: I12e317ada7159101cc5349e9a084b7f316493048
Bug-Url: https://bugzilla.redhat.com/1122691
Related-To: https://bugzilla.redhat.com/1083310
Signed-off-by: Greg Padgett <gpadgett at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMemoryVolumesCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
2 files changed, 17 insertions(+), 5 deletions(-)

Approvals:
  Greg Padgett: Verified
  Allon Mureinik: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/30608
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I12e317ada7159101cc5349e9a084b7f316493048
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list