Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Fix disk alias recycling

oourfali at redhat.com oourfali at redhat.com
Tue Jul 29 13:19:56 UTC 2014


Oved Ourfali has submitted this change and it was merged.

Change subject: webadmin: Fix disk alias recycling
......................................................................


webadmin: Fix disk alias recycling

When creating a new disk via webadmin, the suggested disk alias created the
suggested alias from the VM name concated with the amount of the disk on the
VM + 1, in case all disk were created by that convention, deleting a disk
which is not the last one and adding a new disk resulted in a suggested disk
alias which matches the last disk alias exactly

Change-Id: Ie852fbcf26c0742c610631a121b9bfd706c01218
Signed-off-by: Tal Nisan <tnisan at redhat.com>
Bug-Url: https://bugzilla.redhat.com/1122932
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNextAvailableDiskAliasNameByVMIdQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetNextAvailableDiskAliasNameByVMIdQueryTest.java
2 files changed, 63 insertions(+), 12 deletions(-)

Approvals:
  Tal Nisan: Verified
  Allon Mureinik: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/30783
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie852fbcf26c0742c610631a121b9bfd706c01218
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list