Change in ovirt-engine[master]: webadmin: Exception while showing an error message

lvernia at redhat.com lvernia at redhat.com
Sun Jun 8 07:50:15 UTC 2014


Lior Vernia has submitted this change and it was merged.

Change subject: webadmin: Exception while showing an error message
......................................................................


webadmin: Exception while showing an error message

The regression is caused by
http://gerrit.ovirt.org/#/c/25837
which expected that the new ArrayList(someSize) creates a list of size
someSize. This is not the case so consequently the Collections.fill left the
list empty and consequently the actions.get(actionNum++) failed on an
exception.

Fixed by a simpler and more reliable way of filling a list using a loop and an
add() method.

Change-Id: Ic9714b3b92ff79b3eb12ead5dfb96d22fed41cca
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java
1 file changed, 5 insertions(+), 3 deletions(-)

Approvals:
  Francesco Romani: Verified
  Lior Vernia: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/28408
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9714b3b92ff79b3eb12ead5dfb96d22fed41cca
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list