Change in ovirt-engine[master]: packaging: setup: refactor db credentials plugins

[sbonazzo at redhat.com]

Sandro Bonazzola has submitted this change and it was merged.

Change subject: packaging: setup: refactor db credentials plugins
......................................................................


packaging: setup: refactor db credentials plugins

Move the questions for db credentials to a common place.

Before this change, db creds were always asked about. Move that to
engine so that they are asked if engine is setup.

Other components that need engine db creds should ask for them
with getCredentials.

Let components owners query for db connections credentials before
users of these components, so that users can use them if already
queried.

Use private engine db credentials consts

Change-Id: Id889c9c3ab1dcc6a873a6f5f2f60bff957e616ea
Signed-off-by: Yedidyah Bar David <didi at redhat.com>
Signed-off-by: Sandro Bonazzola <sbonazzo at redhat.com>
---
M packaging/setup/bin/ovirt-engine-upgrade-check
M packaging/setup/ovirt_engine_setup/engine/constants.py
M packaging/setup/ovirt_engine_setup/engine_common/constants.py
M packaging/setup/ovirt_engine_setup/engine_common/database.py
M packaging/setup/plugins/ovirt-engine-common/base/dialog/titles.py
D packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/db/__init__.py
D packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/db/connection.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/db/__init__.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/db/connection.py
R packaging/setup/plugins/ovirt-engine-common/ovirt-engine/db/pgpass.py
M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/db/clear.py
M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py
D packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/db/__init__.py
D packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/db/connection.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/core.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsm.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/appmode.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/database.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/domain_type.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/iso_domain.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/macrange.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/options.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/public_glance_repository.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/__init__.py
A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/connection.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/schema.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/legacy/osinfo.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/provisioning/postgres.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dbvalidations.py
32 files changed, 645 insertions(+), 708 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me, approved
  Simone Tiraboschi: Verified
  oVirt Jenkins CI Server: Looks good to me, but someone else must approve
  Doron Fediuck: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/28701
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id889c9c3ab1dcc6a873a6f5f2f60bff957e616ea
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde at gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server