Change in ovirt-engine[master]: webadmin: runMultipleActions - disable aggregateErrors

derez at redhat.com derez at redhat.com
Tue Jun 17 08:41:29 UTC 2014


Daniel Erez has submitted this change and it was merged.

Change subject: webadmin: runMultipleActions - disable aggregateErrors
......................................................................


webadmin: runMultipleActions - disable aggregateErrors

When 'failureCallback != null', aggregateErrors should be disabled
to allow invocation of an error dialog. Otherwise, on sequentially
running multiple actions of different types, no error
message is being displayed; as a failure in a sequential run
should break the chain and invoke an error dialog rather than
aggregate errors.

A scenario for example: add storage domain dialog ->
enter an invalid nfs path - the execution error dialog
is missing.

Change-Id: Ib7331889f56dc7da7460390411ee3ce9f3604973
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Daniel Erez: Verified
  Lior Vernia: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/28827
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7331889f56dc7da7460390411ee3ce9f3604973
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list