Change in ovirt-engine[master]: engine : if setSucceeded(true) is called before exception co...

[oourfali at redhat.com]

Oved Ourfali has submitted this change and it was merged.

Change subject: engine : if setSucceeded(true) is called before exception command is presented as succeeded
......................................................................


engine : if setSucceeded(true) is called before exception command is presented as succeeded

if any Command calls: getReturnValue().setSucceeded(true);
and after that follows some logic, then if this logic
fails, outcome of this command will be presented as
successful. Compensation/rollbacks etc. are called, but
data sent to user is wrong.

Change-Id: Iee7b186314dacdeeb818c6fdf5157876b0b8342e
Bug-Url: https://bugzilla.redhat.com/1106464
Signed-off-by: Ravi Nori <rnori at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Oved Ourfali: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/28916
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iee7b186314dacdeeb818c6fdf5157876b0b8342e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server