Change in ovirt-engine[master]: engine: Fix coverity complaint

masayag at redhat.com masayag at redhat.com
Wed Jun 25 07:28:09 UTC 2014


Moti Asayag has submitted this change and it was merged.

Change subject: engine: Fix coverity complaint
......................................................................


engine: Fix coverity complaint

CID 1223220 (#1 of 1): Dereference null return value (NULL_RETURNS)
null_method_call: Calling a method on null object jobType.

In addition, the job type is not allowed to be null in vm_job table
hence a default value should be set for it.

Change-Id: If67422d839f16be850b91d9bdfdf58f7359d4672
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Moti Asayag: Verified
  Yair Zaslavsky: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/29097
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If67422d839f16be850b91d9bdfdf58f7359d4672
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list