Change in ovirt-engine[master]: core: Replaced message of GetIsoListError

amureini at redhat.com amureini at redhat.com
Wed Jun 25 14:53:59 UTC 2014


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Replaced message of GetIsoListError
......................................................................


core: Replaced message of GetIsoListError

The getUserRequestForStorageDomainRepoFileList method used to return
null when the storage domain was not valid.
Now it throws a VdcBLLException with GetIsoListError type instead.
Also, an informative message was added to GetIsoListError.
There's no need to catch the exception in 'executeQueryCommand' in
GetImagesListQueryBase or in GetImageByIdQuery because the one who
calls them, QueriesCommandBase, does the job.

Change-Id: I3e6dc6fbe03ffba94cff8821b35eacf062e42362
Bug-Url: https://bugzilla.redhat.com/918949
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListQueryBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
6 files changed, 13 insertions(+), 13 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/29033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3e6dc6fbe03ffba94cff8821b35eacf062e42362
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list