Change in ovirt-engine[master]: core: Use null check for unregistered dal insert

mlipchuk at redhat.com mlipchuk at redhat.com
Thu Jun 26 20:51:00 UTC 2014


Maor Lipchuk has submitted this change and it was merged.

Change subject: core: Use null check for unregistered dal insert
......................................................................


core: Use null check for unregistered dal insert

Architeture and LowestCompVersion are not part of the OVF.
This patch adds a validation so we will not get an NPE when trying to
insert new VMs/Templates from the OVF disk into the DB

Change-Id: I5e7328464c3038d9298723e947fbf262e74c9df6
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAODbFacadeImpl.java
1 file changed, 13 insertions(+), 8 deletions(-)

Approvals:
  Allon Mureinik: Looks good to me, approved
  Maor Lipchuk: Verified; Looks good to me, approved
  Liron Aravot: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/29040
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5e7328464c3038d9298723e947fbf262e74c9df6
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list