Change in ovirt-engine[master]: db: cleanup: psql usage

[emesika at redhat.com]

Eli Mesika has submitted this change and it was merged.

Change subject: db: cleanup: psql usage
......................................................................


db: cleanup: psql usage

1. all command to use single psql wrapper

2. parser friendly psql wrapper without need to perform text
   manipulation including escaping.

3. extract base psql functionality into own dbfunc-base.sh to be used by
   dbutils as well.

4. prefix dbfunc variables to avoid duplications and have clearer code.

5. reformat complex sqls to multi line notation.

6. remove the no md5 parameter in favor for md5dir exist/absent.

7. boolean as -z -n

8. minor additional cleanups.

Change-Id: Ib93ad2ca4d35fe3f44e3f8915182778a9fe6ed66
Signed-off-by: Alon Bar-Lev <alonbl at redhat.com>
---
M packaging/dbscripts/cleandb.sh
M packaging/dbscripts/create_schema.sh
M packaging/dbscripts/dbcustomfunctions.sh
A packaging/dbscripts/dbfunc-base.sh
M packaging/dbscripts/dbfunctions.sh
M packaging/dbscripts/refreshStoredProcedures.sh
M packaging/dbscripts/unlock_entity.sh
M packaging/dbscripts/upgrade.sh
M packaging/setup/dbutils/changedbowner.sh
D packaging/setup/dbutils/common.sh
A packaging/setup/dbutils/dbfunc-base.sh
M packaging/setup/dbutils/encodingvalidator.sh
M packaging/setup/dbutils/fkvalidator.sh
M packaging/setup/dbutils/taskcleaner.sh
M packaging/setup/dbutils/validatedb.sh
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/schema.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dbvalidations.py
18 files changed, 631 insertions(+), 506 deletions(-)

Approvals:
  Alon Bar-Lev: Verified
  Eli Mesika: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/25216
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib93ad2ca4d35fe3f44e3f8915182778a9fe6ed66
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org