Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Saving a dialog pressing ENTER inconsistent with c...

iheim at redhat.com iheim at redhat.com
Thu Mar 6 17:38:25 UTC 2014


Itamar Heim has submitted this change and it was merged.

Change subject: webadmin: Saving a dialog pressing ENTER inconsistent with clicking OK
......................................................................


webadmin: Saving a dialog pressing ENTER inconsistent with clicking OK

When clicking on OK button (or any other footer button) the view is
flushed before the command is executed.
Pressing "ESC" or "ENTER" should be consistent with clicking the
footer button "CANCEL" or "OK".

Change-Id: Iaf0e2d0de5f905af13d99eec5f7403bb72b8f02c
Bug-Url: https://bugzilla.redhat.com/1059578
Signed-off-by: Alona Kaplan <alkaplan at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Alona Kaplan: Verified
  Lior Vernia: Looks good to me, approved
  Oved Ourfali: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/25383
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf0e2d0de5f905af13d99eec5f7403bb72b8f02c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list