Change in ovirt-engine[ovirt-engine-3.4]: core: VURTI - fix handle expection in GetVmStats

[iheim at redhat.com]

Itamar Heim has submitted this change and it was merged.

Change subject: core: VURTI - fix handle expection in GetVmStats
......................................................................


core: VURTI - fix handle expection in GetVmStats

after getting all vms with List command, VURTI loops through them
to update internal structure data. BUT if the call fails, VURTI removes
the VM from the internal running map - this leads to a split-brains
for VURTI assumes the Vm is DOWN and if it HA, its runs it.

the fix is to exclude this Vm from the list of the vms that have changed
this is similar to a case where Vm didn't changed its status

UNIT TEST
added a unit test to make sure the VM is kept in the map
although the call to GetVmStats didn't made it

Bug-Url: https://bugzilla.redhat.com/1072282
Change-Id: I415804d9fa1f1288423241b8547f4cab5540914a
Signed-off-by: Roy Golan <rgolan at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfoTest.java
3 files changed, 172 insertions(+), 40 deletions(-)

Approvals:
  Roy Golan: Verified
  Omer Frenkel: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/25599
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I415804d9fa1f1288423241b8547f4cab5540914a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server