Change in ovirt-engine[master]: core: disable command's logging on runningFailed

ahadas at redhat.com ahadas at redhat.com
Mon Mar 24 13:14:35 UTC 2014


Arik Hadas has submitted this change and it was merged.

Change subject: core: disable command's logging on runningFailed
......................................................................


core: disable command's logging on runningFailed

After calling RunVmCommandBase#runningFailed the automatic logging
should be disabled since the 'log()' method is called directly by this
method. A call to 'setCommandShouldBeLogged(false)' was added inside
RunVmCommandBase#runningFailed.

It is safe since this method is called on rerun flows, where the
automatic logging is not invoked anyway, and from one place as part of
the execution phase where the automatic logging is already disabled.

Change-Id: Ied9130d2e8dacb94924da220e8ba1a1f1204e681
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
2 files changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Arik Hadas: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/25574
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ied9130d2e8dacb94924da220e8ba1a1f1204e681
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list