Change in ovirt-engine[master]: webadmin: fixed generics in EnumTranslator, fixed typo

gchaplik at redhat.com gchaplik at redhat.com
Thu Mar 27 09:58:43 UTC 2014


Gilad Chaplik has submitted this change and it was merged.

Change subject: webadmin: fixed generics in EnumTranslator, fixed typo
......................................................................


webadmin: fixed generics in EnumTranslator, fixed typo

Parameterized EnumTranslator could accept any type, not just Enums,
which is wrong. Constructor accepted also any type, but it was
expected (not reinforced) that this type will be
Class<? extends Enum<?>>.

Change-Id: If835e719a497e7ab1db4fc4f9484354e838c60c5
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EnumTranslator.java
1 file changed, 9 insertions(+), 9 deletions(-)

Approvals:
  Martin Mucha: Verified
  Alona Kaplan: Looks good to me, approved
  Gilad Chaplik: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/25605
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If835e719a497e7ab1db4fc4f9484354e838c60c5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list