Change in ovirt-engine[master]: engine: Send ifaceName and tpgt in connectStorageServer

amureini at redhat.com amureini at redhat.com
Sat Mar 29 08:54:29 UTC 2014


Allon Mureinik has submitted this change and it was merged.

Change subject: engine: Send ifaceName and tpgt in connectStorageServer
......................................................................


engine: Send ifaceName and tpgt in connectStorageServer

Engine mistakenly sent initiatorName instead of ifaceName which overwrote
existing initiatorName configured in the host. Wrong initiatorName caused
host fail to perform iSCSI connection.

In case of tpgt the problem is terminology. Engine sent it as a "portal"
and its value is integer,  but from the iSCSI perspective portal is an
access point to one or more targets, while this integer actually
represents a tpgt - target portal group tag which is numeric representation
of which IP addresses a target is allowed to bind on.

Bug-Url: https://bugzilla.redhat.com/1078137
Change-Id: Ife467feb8aad9711da5d6a5df305e50fe6bf51e9
Signed-off-by: Sergey Gotliv <sgotliv at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Sergey Gotliv: Verified
  Allon Mureinik: Looks good to me, approved
  Maor Lipchuk: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/25890
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ife467feb8aad9711da5d6a5df305e50fe6bf51e9
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list