Change in ovirt-engine-sdk[sdk_3.4]: codegen: Allow = in replaced function parameters

juan.hernandez at redhat.com juan.hernandez at redhat.com
Tue May 6 17:23:43 UTC 2014


Juan Hernandez has submitted this change and it was merged.

Change subject: codegen: Allow = in replaced function parameters
......................................................................


codegen: Allow = in replaced function parameters

The code generator replaces some of the functions in the params.py file
generated by generateDS.py. To locate these functions it uses regular
expressions, but it doesn't take into account that parameters can
contain the equals sign. In version 2.9a of generateDS.py the generated
functions didn't have parameters with default values, so the equals sign
wasn't present:

  def parseString(inString)

In version 2.12a of generateDS.py the generated functions have
parameters with default values:

  def parseString(inString, silence=False)

This patch changes the code generator so that it will locate the
functions correctly in both cases, with or without the equals sign.

Change-Id: I7eccef883def440e04e47a7e04c476a3d3348a91
Related: https://bugzilla.redhat.com/1091688
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
(cherry picked from commit 7d9add1515fedbb6ce87c39331f35de19563d190)
---
M src/codegen/xsd/genparams.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/27429
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7eccef883def440e04e47a7e04c476a3d3348a91
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_3.4
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list