Change in ovirt-engine[master]: engine: RemoveNetworksByLabelParametersBuilder accepts any v...

alkaplan at redhat.com alkaplan at redhat.com
Wed May 7 07:16:54 UTC 2014


Alona Kaplan has submitted this change and it was merged.

Change subject: engine: RemoveNetworksByLabelParametersBuilder accepts any vlan device name
......................................................................


engine: RemoveNetworksByLabelParametersBuilder accepts any vlan device name

Changes done in this patch-
1. The builder uses iface.getBaseInterface() and iface.getVlanId() instead
of determining this values from the vlan device name (since its format is
no longer- baseIface.vlanId).
2. The builder uses the new methods indroduced in NetworkUtils instead of
the old ones (that should be removed in a following patch).

Change-Id: If22225ae3d971aa6072b161df0965dd663deff1e
Bug-Url: https://bugzilla.redhat.com/1091863
Bug-Url: https://bugzilla.redhat.com/999975
Signed-off-by: Alona Kaplan <alkaplan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworksByLabelParametersBuilder.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Mike Kolesnik: Looks good to me, approved
  Alona Kaplan: Verified



-- 
To view, visit http://gerrit.ovirt.org/26610
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If22225ae3d971aa6072b161df0965dd663deff1e
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list