Change in ovirt-engine[master]: engine: refactoring NetworkUtils.getVlanDeviceName

alkaplan at redhat.com alkaplan at redhat.com
Wed May 7 07:20:25 UTC 2014


Alona Kaplan has submitted this change and it was merged.

Change subject: engine: refactoring NetworkUtils.getVlanDeviceName
......................................................................


engine: refactoring NetworkUtils.getVlanDeviceName

This patch changes the method name to constructVlanDeviceName.
The method should be used only for constructing new vlan devices.
Other places shoulded assume the vlan device name is in format-
baseIface.vlanId

Change-Id: I34ed8b14fb8e22d9681bdbc34d863c52b6d23be5
Bug-Url: https://bugzilla.redhat.com/1091863
Bug-Url: https://bugzilla.redhat.com/999975
Signed-off-by: Alona Kaplan <alkaplan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkParametersBuilder.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
2 files changed, 7 insertions(+), 3 deletions(-)

Approvals:
  Mike Kolesnik: Looks good to me, approved
  Alona Kaplan: Verified



-- 
To view, visit http://gerrit.ovirt.org/27152
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I34ed8b14fb8e22d9681bdbc34d863c52b6d23be5
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list