Change in ovirt-engine[master]: engine: Adjust NetworkUtils to accept any vlan device name -...

alkaplan at redhat.com alkaplan at redhat.com
Wed May 7 07:20:45 UTC 2014


Alona Kaplan has submitted this change and it was merged.

Change subject: engine: Adjust NetworkUtils to accept any vlan device name - phase 2
......................................................................


engine: Adjust NetworkUtils to accept any vlan device name - phase 2

This patch contains-
1. Removing from all the old methods assuming vlan device name format is
baseNic.vlanId from NetworkUtils.
2. Fixing NetworkUtilsTest.

The patch is the last one in a chain of patches.
The previous patches fixed all the places thats used the old methods.

Change-Id: I884ea51d4c7b47fef2b7fb2c89b4efd36701980c
Bug-Url: https://bugzilla.redhat.com/1091863
Bug-Url: https://bugzilla.redhat.com/999975
Signed-off-by: Alona Kaplan <alkaplan at redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NetworkUtilsTest.java
2 files changed, 17 insertions(+), 75 deletions(-)

Approvals:
  Mike Kolesnik: Looks good to me, approved
  Alona Kaplan: Verified



-- 
To view, visit http://gerrit.ovirt.org/27153
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I884ea51d4c7b47fef2b7fb2c89b4efd36701980c
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list