Change in ovirt-engine[master]: core: extract current implementation to strategy.

masayag at redhat.com masayag at redhat.com
Wed May 14 20:36:19 UTC 2014


Moti Asayag has submitted this change and it was merged.

Change subject: core: extract current implementation to strategy.
......................................................................


core: extract current implementation to strategy.

Because we need to find out better solution than current, we need to
have multiple of them coexisting to compare them. Implementation of
static methods of MacPoolManager.java is thus extracted out, to
implementation of interface MacPoolManagerStrategy.java. All static
methods of MacPoolManager.java remain where they were, but for the
actual work they delegate to MacPoolManagerOriginal.java

Change-Id: I75498bb68ec6dbe28650027116bf44a0797faf93
Bug-Url: https://bugzilla.redhat.com/1063064
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManagerOriginal.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManagerStrategy.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java
4 files changed, 461 insertions(+), 325 deletions(-)

Approvals:
  Moti Asayag: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/26400
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I75498bb68ec6dbe28650027116bf44a0797faf93
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list