Change in ovirt-engine[master]: utils: return an unmodifiable map for ShellLikeConfd.getProp...

oourfali at redhat.com oourfali at redhat.com
Thu May 15 11:17:52 UTC 2014


Oved Ourfali has submitted this change and it was merged.

Change subject: utils: return an unmodifiable map for ShellLikeConfd.getProperties()
......................................................................


utils: return an unmodifiable map for ShellLikeConfd.getProperties()

Without wrapping users can unexpectedly change internal
values after calling getProperties().

Change-Id: I33c5e05b5e433634575285e19b435127dd0ae968
Signed-off-by: Mooli Tayer <mtayer at redhat.com>
---
M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/config/ShellLikeConfd.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Alon Bar-Lev: Looks good to me, but someone else must approve
  mooli tayer: Verified
  Oved Ourfali: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/27526
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I33c5e05b5e433634575285e19b435127dd0ae968
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list