Change in ovirt-engine[master]: webadmin, userportal: Use GWTP Bootstrapper for ApplicationInit

[vszocs at redhat.com]

Vojtech Szocs has submitted this change and it was merged.

Change subject: webadmin,userportal: Use GWTP Bootstrapper for ApplicationInit
......................................................................


webadmin,userportal: Use GWTP Bootstrapper for ApplicationInit

Before this patch, ApplicationInit classes were bound in
GIN SystemModule as eager singletons. This was to ensure
that these classes are instantiated right after Ginjector
is created, i.e. before GWTP place transition kicks in.

After this patch, ApplicationInit classes implement GWTP
Bootstrapper interface, effectively replacing the use of
DefaultBootstrapper (built-in GWTP fallback). The role of
GWTP Bootstrapper is to perform any application-specific
initialization before initiating transition to requested
application place, as defined by history token within the
URL.

By utilizing GWTP Bootstrapper feature, we no longer have
to rely on eager singletons to perform initialization at
application startup.

Change-Id: I31472c718678ef2ccd45fbf1d988f3faa49bb54d
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/SystemModule.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/system/ApplicationInit.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/UserPortal.gwt.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/SystemModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/WebAdmin.gwt.xml
7 files changed, 50 insertions(+), 12 deletions(-)

Approvals:
  Vojtech Szocs: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/25209
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I31472c718678ef2ccd45fbf1d988f3faa49bb54d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server