Change in ovirt-engine[master]: core: remove jobs of IVdsAsyncCommands on engine startup

ahadas at redhat.com ahadas at redhat.com
Thu May 22 11:12:07 UTC 2014


Arik Hadas has submitted this change and it was merged.

Change subject: core: remove jobs of IVdsAsyncCommands on engine startup
......................................................................


core: remove jobs of IVdsAsyncCommands on engine startup

Since commands that inherit from IVdsAsyncCommand are not saved to db,
after engine restart we cannot continue to track them. That also means
that the jobs of such commands are not cleaned after engine restarts.

The solution is to remove the jobs of such commands that remained in
running ('STARTED') state. It is safe to do so because the commands are
not restored after the restart so no one will try to access those jobs.

Change-Id: I5973c05f41b90ec48c2961c6f89f5aa110944d6d
Bug-Url: https://bugzilla.redhat.com/1040952
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/JobDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/JobDaoDbFacadeImpl.java
M packaging/dbscripts/job_sp.sql
4 files changed, 22 insertions(+), 0 deletions(-)

Approvals:
  Omer Frenkel: Looks good to me, approved
  Arik Hadas: Verified



-- 
To view, visit http://gerrit.ovirt.org/27372
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5973c05f41b90ec48c2961c6f89f5aa110944d6d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list