Change in ovirt-engine[master]: engine: Add custom mount options to NFS SD

amureini at redhat.com amureini at redhat.com
Fri May 23 07:35:24 UTC 2014


Allon Mureinik has submitted this change and it was merged.

Change subject: engine: Add custom mount options to NFS SD
......................................................................


engine: Add custom mount options to NFS SD

This patch allows to set custom mount options to NFS based storage
domains through the webadmin and rest interfaces.

The mechanism is the same one that's implemented for PosixFS storage
domain:
 * An extra input field is added to the connection interface for the
   custom mount options in the webadmin interface.
 * The mount_options parameter is accepted when using the rest interface.

Those parameters, then, are sent with the other mount options to VDSM
storage server.

Change-Id: I3c7d51f5bf1ffb3491788b9fcda770a55b94cf50
Bug-Url: https://bugzilla.redhat.com/1087059
Signed-off-by: Xavi Francisco <xfrancis at redhat.com>
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageDomainMapperTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.ui.xml
7 files changed, 63 insertions(+), 4 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/27694
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3c7d51f5bf1ffb3491788b9fcda770a55b94cf50
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xavi Francisco <xfrancis at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Xavi Francisco <xfrancis at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list