Change in ovirt-engine[master]: backend: RNG device sources reporting

[ofrenkel at redhat.com]

Omer Frenkel has submitted this change and it was merged.

Change subject: backend: RNG device sources reporting
......................................................................


backend: RNG device sources reporting

This is a follow-up to original VirtIO RNG patches (18176, 18497).

This patch adds
 - required rng sources to cluster (set by admin),
 - supported rng sources to host (reported by VDSM).

The host-supported rng sources must comply with cluster-required rng
sources, otherwise corresponding host is set to non-operational state.

Configuration:
- VirtioRngDeviceSupported config value which cluster versions are
  allowed to operate with virtio rng devices
- ClusterRequiredRngSourcesDefault config value contains comma-separated
  value with rng device sources that are required by newly created
  clusters (e.g. "random,hwrng")

(Notable) affected behavior:
- rng device crud:
  - AddRngDeviceCommand: the rng device is not added when it's source
  doesn't comply with the cluster required rng sources
  - UpdateRngDeviceCommand - now when the admin
  weakens the rng sources requirements for a cluster but some VM in this
  cluster has a random number generator device with this source
  assigned, this device is deleted when UpdateRngDeviceCommand is
  invoked (which happens on VM/Template update).
- cluster crud:
  - when adding/updating cluster, the logic checks if its version
  supports rng devices (configurable via VirtioRngDeviceSupported).

Change-Id: Id60a39118aef439146e6f0f308eec84e1ccaab9a
Signed-off-by: Frantisek Kobzik <fkobzik at redhat.com>
Bug-Url: https://bugzilla.redhat.com/977079
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractRngDeviceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRngDeviceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateRngDeviceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateRngDeviceTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NonOperationalReason.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategyTest.java
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/03_05_0500_add_rng_device_columns.sql
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/dbscripts/vds_groups_sp.sql
M packaging/dbscripts/vds_sp.sql
28 files changed, 251 insertions(+), 29 deletions(-)

Approvals:
  Omer Frenkel: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22258
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id60a39118aef439146e6f0f308eec84e1ccaab9a
Gerrit-PatchSet: 37
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server