Change in ovirt-engine[ovirt-engine-3.5]: core: osinfo - fail backend startup on coliding os id error

[tnisan at redhat.com]

Tal Nisan has submitted this change and it was merged.

Change subject: core: osinfo - fail backend startup on coliding os id error
......................................................................


core: osinfo - fail backend startup on coliding os id error

fail loading the backend by throwing a RuntimeException if an osinfo
properties have colliding id's.

e.g

os.linux.id.value = 12345
os.windows.id.value = 12345

obviously wrong and should fail with logged exception

"java.lang.RuntimeException: colliding os id 12345 at node /os/windows/id"

Change-Id: I9f19a1d33336f020b1ff71d9bcfd06eaee45e81d
Bug-Url: https://bugzilla.redhat.com/996055
Signed-off-by: Roy Golan <rgolan at redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OsRepositoryImplTest.java
2 files changed, 21 insertions(+), 1 deletion(-)

Approvals:
  Roy Golan: Verified
  Omer Frenkel: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/34740
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9f19a1d33336f020b1ff71d9bcfd06eaee45e81d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server