Change in ovirt-engine[ovirt-engine-3.5]: core: Renamed StorageDomainDAO.getStorageDomainByTypeAndPool
tnisan at redhat.com
tnisan at redhat.com
Thu Nov 6 16:35:52 UTC 2014
Tal Nisan has submitted this change and it was merged.
Change subject: core: Renamed StorageDomainDAO.getStorageDomainByTypeAndPool
......................................................................
core: Renamed StorageDomainDAO.getStorageDomainByTypeAndPool
The method's parameters types are clear enough, so there's no need to
include them also in the method's name.
Change-Id: Iffc63c3a22488e459be3c9beac9dd5d0163f0d12
Related-To: https://bugzilla.redhat.com/1085398
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDAOTest.java
4 files changed, 8 insertions(+), 7 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Idan Shaby: Verified
Objections:
automation at ovirt.org: Fails
--
To view, visit http://gerrit.ovirt.org/34864
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iffc63c3a22488e459be3c9beac9dd5d0163f0d12
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the Engine-commits
mailing list