Change in ovirt-engine[master]: Revert "core: Improve performance of getdisksvmguid"

amureini at redhat.com amureini at redhat.com
Sun Nov 9 08:47:19 UTC 2014


Allon Mureinik has submitted this change and it was merged.

Change subject: Revert "core: Improve performance of getdisksvmguid"
......................................................................


Revert "core: Improve performance of getdisksvmguid"

This reverts commit d9e489471aaf0113fac7dff63845dee6f7f4523e.

UNION removes duplicate records, UNION ALL does not.
Hence, 'all_disks_including_snapshots' view includes duplicate
records for copied template disks.
Performance improvement should probably be achieved in another way.
In the mean time, reverting this change.

Change-Id: I5f6a0859a6000124e7968e5725ed7e5232b1a5cf
Bug-Url: https://bugzilla.redhat.com/1161612
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M packaging/dbscripts/create_views.sql
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Daniel Erez: Verified
  Allon Mureinik: Looks good to me, approved
  Liran Zelkha: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/34958
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5f6a0859a6000124e7968e5725ed7e5232b1a5cf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list