Change in ovirt-engine[master]: core: Remove redundant Vds call at Add existingFileStorageDo...

mlipchuk at redhat.com mlipchuk at redhat.com
Thu Nov 13 07:51:39 UTC 2014


Maor Lipchuk has submitted this change and it was merged.

Change subject: core: Remove redundant Vds call at Add existingFileStorageDomain
......................................................................


core: Remove redundant Vds call at Add existingFileStorageDomain

Remove redundant getStorageDomainsList VDS call.
The call was used to know if the Storage Exists in the VDSM, but we can
also know that from the next VDS command of getStorageDomainInfo.
Changing the test accordingly

Change-Id: I2294f83eb204cab44b6a52e7c7a763bf107aaa37
Bug-Url: https://bugzilla.redhat.com/1157240
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommandTest.java
2 files changed, 18 insertions(+), 21 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Maor Lipchuk: Verified



-- 
To view, visit http://gerrit.ovirt.org/34540
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2294f83eb204cab44b6a52e7c7a763bf107aaa37
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list