Change in ovirt-engine[ovirt-engine-3.5]: engine : Set endAction try again to false on failure

oourfali at redhat.com oourfali at redhat.com
Sun Nov 16 10:57:19 UTC 2014


Oved Ourfali has submitted this change and it was merged.

Change subject: engine : Set endAction try again to false on failure
......................................................................


engine : Set endAction try again to false on failure

On failure of commands with handlers, if no handler
has been executed the endWithFailure is not invoked
on the handlers. This can leave setEndActionTryAgain to
true causing AsyncTaskManager to continuously wait for
commands completion. In such cases the CommandBase should
set the setEndActionTryAgain to false so the command
can converge.

Change-Id: Idf6f8755a22f2654b9af6678f1353f9b6ae08942
Bug-Url: https://bugzilla.redhat.com/1159325
Signed-off-by: Ravi Nori <rnori at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Oved Ourfali: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/34942
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idf6f8755a22f2654b9af6678f1353f9b6ae08942
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list