Change in ovirt-engine[ovirt-engine-3.5]: core: Remove redundant Vds call at Add existingFileStorageDo...

tnisan at redhat.com tnisan at redhat.com
Sun Nov 16 15:34:22 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: core: Remove redundant Vds call at Add existingFileStorageDomain
......................................................................


core: Remove redundant Vds call at Add existingFileStorageDomain

Remove redundant getStorageDomainsList VDS call.
The call was used to know if the Storage Exists in the VDSM, but we can
also know that from the next VDS command of getStorageDomainInfo.
Changing the test accordingly

Change-Id: I2294f83eb204cab44b6a52e7c7a763bf107aaa37
Bug-Url: https://bugzilla.redhat.com/1157240
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java
1 file changed, 10 insertions(+), 17 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Maor Lipchuk: Verified



-- 
To view, visit http://gerrit.ovirt.org/35108
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2294f83eb204cab44b6a52e7c7a763bf107aaa37
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list