Change in ovirt-engine[master]: webadmin: Simplify report redirect

awels at redhat.com awels at redhat.com
Fri Nov 21 18:06:59 UTC 2014


Alexander Wels has submitted this change and it was merged.

Change subject: webadmin: Simplify report redirect
......................................................................


webadmin: Simplify report redirect

- Reports had several redirect servlet instances, one for each type
  of interaction with the reporting server. The difference was
  parameters defined in the configuration. This patch passes the
  parameters to the UI using the host page instead of new servlets
  in web.xml.
- Added parsing method to HtmlParameters to preserve parameters on
  the url.
- Fixed SSO issue where if a user was already logged in it would provide
  the wrong SSO token and report integration would fail.

Change-Id: Ic4718bf7f734ea72d2494fc463a87cb7675df0c4
Signed-off-by: Alexander Wels <awels at redhat.com>
---
M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml
M backend/manager/modules/services/src/main/webapp/WEB-INF/web.xml
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/RedirectServlet.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServlet.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/utils/FrontendUrlUtils.java
M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp
M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServletTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/HtmlParameters.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportInit.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportsUrls.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportsListModel.java
12 files changed, 130 insertions(+), 30 deletions(-)

Approvals:
  Alexander Wels: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/33550
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4718bf7f734ea72d2494fc463a87cb7675df0c4
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list