Change in ovirt-engine[master]: core: Fix CDA for AddVmCommand

shavivi at redhat.com shavivi at redhat.com
Tue Nov 25 07:49:32 UTC 2014


Shahar Havivi has submitted this change and it was merged.

Change subject: core: Fix CDA for AddVmCommand
......................................................................


core: Fix CDA for AddVmCommand

The command allowed a user to add a VM using REST before the DC was initialized,
this VM caused problems in some flows. Added a check for the storage pool status
that will cause the command to fail when the DC is down.

Change-Id: I2586b0026c85f053b6cd0aebeb555d760afc0937
Bug-Url: https://bugzilla.redhat.com/1157229
Signed-off-by: Eldan Shachar <eshachar at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
2 files changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Eldan Shachar: Verified
  Shahar Havivi: Looks good to me, approved
  Arik Hadas: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/35454
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2586b0026c85f053b6cd0aebeb555d760afc0937
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eldan Shachar <eshachar at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Eldan Shachar <eshachar at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list