Change in ovirt-engine[ovirt-engine-3.5]: core: Add try/catch block in end action of ExportVmCommand

tnisan at redhat.com tnisan at redhat.com
Sat Nov 29 21:33:06 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: core: Add try/catch block in end action of ExportVmCommand
......................................................................


core: Add try/catch block in end action of ExportVmCommand

When exporting a VM with the collapse snapshot option, the VM ovf is
updated after the images export ends successfully. If this operation will
fail and throw an exception the source VM will be stayed in locked status.
This patch surrounds the operation with a try/catch block in order to log
the fault and continue the end action correctly to unlock the VM and it's
disks.

Bug-Url: https://bugzilla.redhat.com/1167297
Change-Id: I67e5119f0f65ce77bc30b6762192e927c88c4434
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
3 files changed, 13 insertions(+), 3 deletions(-)

Approvals:
  Tal Nisan: Verified
  Allon Mureinik: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/35699
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I67e5119f0f65ce77bc30b6762192e927c88c4434
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list