Change in ovirt-engine[ovirt-engine-3.5]: core: Log error correctly when connecting domain for removal

tnisan at redhat.com tnisan at redhat.com
Sun Oct 5 12:39:14 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: core: Log error correctly when connecting domain for removal
......................................................................


core: Log error correctly when connecting domain for removal

When connecting to a storage domain as a part of its removal (or format
in case of ISO domains) if the connection fails, the error is not logged
correctly and instead we get a generic error, this was fixed and instead
the generic error we will get the real cause

Change-Id: Idd7435336acbec41edbdd70568f1dfdce664f875
Bug-Url: https://bugzilla.redhat.com/1003266
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseFsStorageHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FCPStorageHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommandTest.java
7 files changed, 56 insertions(+), 25 deletions(-)

Approvals:
  Tal Nisan: Verified
  Allon Mureinik: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/33809
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idd7435336acbec41edbdd70568f1dfdce664f875
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list