Change in ovirt-engine[master]: core: dont copy old num of sockets on hotplug

ofrenkel at redhat.com ofrenkel at redhat.com
Tue Oct 14 07:16:29 UTC 2014


Omer Frenkel has submitted this change and it was merged.

Change subject: core: dont copy old num of sockets on hotplug
......................................................................


core: dont copy old num of sockets on hotplug

when editing running vm, all fields that are not editable, are copied
from the old vm to new vm, as they are saved in the running snapshot,
and db reflect the actual running config.

when user select to do hot-set to cpu, the number of sockets should not
be copied with the old value, as it is used in the hot-set command.

this is fixed by sending to the copy method, if this is a hot-set flow,
and it will check it when doing copy of the old value, for hot-set allowed fields.

Change-Id: I57bcd2287350c3146f06fe2a5c9a583c88dded04
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1151827
Signed-off-by: Omer Frenkel <ofrenkel at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java
3 files changed, 19 insertions(+), 8 deletions(-)

Approvals:
  Omer Frenkel: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/34069
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I57bcd2287350c3146f06fe2a5c9a583c88dded04
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list