Change in ovirt-engine[ovirt-engine-3.5]: core: RemoveDiskSnapshots - sort images from parent to leaf

[tnisan at redhat.com]

Tal Nisan has submitted this change and it was merged.

Change subject: core: RemoveDiskSnapshots - sort images from parent to leaf
......................................................................


core: RemoveDiskSnapshots - sort images from parent to leaf

When removing multiple disk snapshots that belongs to the same disk,
the images should be sorted from parent to leaf (active).
Sorting is needed since removing a child image and a parent image
afterwards, might be invalid - as the parent will point to another child
and when deletion is done in consecutive order there's a race condition
between DB update and removing next parent.

Change-Id: I759537f7c32fc9b19a968f32767bba633f3f3366
Bug-Url: https://bugzilla.redhat.com/1151841
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java
2 files changed, 24 insertions(+), 1 deletion(-)

Approvals:
  Daniel Erez: Verified
  Maor Lipchuk: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/34141
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I759537f7c32fc9b19a968f32767bba633f3f3366
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server