Change in ovirt-engine[master]: core: refactoring in UpdateVmVersionCommand

ahadas at redhat.com ahadas at redhat.com
Wed Oct 15 10:14:01 UTC 2014


Arik Hadas has submitted this change and it was merged.

Change subject: core: refactoring in UpdateVmVersionCommand
......................................................................


core: refactoring in UpdateVmVersionCommand

- extract parameters initialization to separate method
- rename removeVmFromPoolParas to removeVmFromPoolParams
- prevent possible NPE on getExclusiveLocks

Change-Id: Id9626104a21060dcef1a60beb1b83873037f779b
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmVersionCommand.java
1 file changed, 44 insertions(+), 30 deletions(-)

Approvals:
  Arik Hadas: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/34068
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id9626104a21060dcef1a60beb1b83873037f779b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list