Change in ovirt-engine[ovirt-engine-3.5]: aaa: Change the check of internal command execution

oourfali at redhat.com oourfali at redhat.com
Thu Oct 23 08:39:02 UTC 2014


Oved Ourfali has submitted this change and it was merged.

Change subject: aaa: Change the check of internal command execution
......................................................................


aaa: Change the check of internal command execution

Both canDoAction and executeAction set the isSucceeded flag
to false if they fail.
We should check if AddUser or AddGroup failed not just by their
canDoAction phase, but also by their execution phase.
Hence, using the isSuceeded flag is more appropriate solution.

Bug-Url: https://bugzilla.redhat.com/1121954
Change-Id: Ie7093e3e20387c2cb9d56c818ac4b74d49b07ad1
Topic: AAA
Signed-off-by: Yair Zaslavsky <yzaslavs at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Alon Bar-Lev: Looks good to me, but someone else must approve
  Oved Ourfali: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/34300
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7093e3e20387c2cb9d56c818ac4b74d49b07ad1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list