Change in ovirt-engine[master]: webadmin: Cluster sub general tab broken

awels at redhat.com awels at redhat.com
Thu Oct 30 12:17:19 UTC 2014


Alexander Wels has submitted this change and it was merged.

Change subject: webadmin: Cluster sub general tab broken
......................................................................


webadmin: Cluster sub general tab broken

- For certain locales the cluster general sub tab would not
  popuplate its values. This was due to an exception being
  thrown in the value parser of read only fields. Since these
  field are readonly they don't need a parser.
- Added a new EntityModelLabelEditor constructor without a parser
  that is meant for readonly fields.

Change-Id: I9c7a911d7a6ecfe79ee006be46e0ef8e627b97e3
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1157380
Signed-off-by: Alexander Wels <awels at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelLabelEditor.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGeneralView.java
3 files changed, 21 insertions(+), 24 deletions(-)

Approvals:
  Alexander Wels: Verified
  Kanagaraj M: Looks good to me, but someone else must approve
  Greg Sheremeta: Looks good to me, but someone else must approve
  Vojtech Szocs: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/34614
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9c7a911d7a6ecfe79ee006be46e0ef8e627b97e3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list