Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: Fix layout issues in vNIC dialog

tnisan at redhat.com tnisan at redhat.com
Mon Sep 1 09:56:25 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: userportal,webadmin: Fix layout issues in vNIC dialog
......................................................................


userportal,webadmin: Fix layout issues in vNIC dialog

There were all sorts of layout issues in the dialog in different
locales. This fixes all of them; more space is allocated to the radio
button labels which fixes breakage, and it's put at the end of the
dialog (so all aligned text boxes will appear first).

Change-Id: I31877f7f2370bd92161d2792533e410f16bf0254
Bug-Url: https://bugzilla.redhat.com/1032519
Bug-Url: https://bugzilla.redhat.com/1079877
Bug-Url: https://bugzilla.redhat.com/1115018
Bug-Url: https://bugzilla.redhat.com/1120976
Bug-Url: https://bugzilla.redhat.com/1123747
Signed-off-by: Lior Vernia <lvernia at redhat.com>
(cherry picked from commit f3dc89c433c9aa5c7eb4a08a9f7fb4d8b967e2ad)
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.ui.xml
2 files changed, 24 insertions(+), 41 deletions(-)

Approvals:
  Alona Kaplan: Looks good to me, approved
  Lior Vernia: Verified



-- 
To view, visit http://gerrit.ovirt.org/31690
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I31877f7f2370bd92161d2792533e410f16bf0254
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list