Change in ovirt-engine[master]: core: setupNetworks not able to configure bridge

oourfali at redhat.com oourfali at redhat.com
Mon Sep 8 16:17:19 UTC 2014


Oved Ourfali has submitted this change and it was merged.

Change subject: core: setupNetworks not able to configure bridge
......................................................................


core: setupNetworks not able to configure bridge

For 2 calls we use ThreadPoolUtil. It was used to provide async network
call for xmlrpc. Jsonrpc is async so from its prespective it makes no
sense to use it. In order to keep the communication interface unchanged
we need to returned Future.

The future checked whether the call was executed not whether the
response arrived. This patch makes sure that we wait for response and
expose this information correctly.


Bug-Url: https://bugzilla.redhat.com/1136876
Change-Id: I70bfa5d7f154a13f7d52f7710eb109de1da0b82c
Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/FutureMap.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
M ovirt-engine.spec.in
M pom.xml
4 files changed, 106 insertions(+), 25 deletions(-)

Approvals:
  Oved Ourfali: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/32469
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I70bfa5d7f154a13f7d52f7710eb109de1da0b82c
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list