Change in ovirt-engine[master]: core: Reduce # of calls to getVdsGroupByVdsGroupId

oourfali at redhat.com oourfali at redhat.com
Tue Sep 9 06:51:24 UTC 2014


Oved Ourfali has submitted this change and it was merged.

Change subject: core: Reduce # of calls to getVdsGroupByVdsGroupId
......................................................................


core: Reduce # of calls to getVdsGroupByVdsGroupId

Since vds view is built on top of the vds_groups table (in addition to
other tables), this patch adds to vds the enable_ballon property so that
we don't need to load the full VdsGroup to get this value.

This saves ~90% of calls to getVdsGroupByVdsGroupId in an idle scenario,
each of these calls takes ~300us (depending on the number of clusters a
customer has).

Change-Id: I9d838a19e0496951b9821936bd3af215e3a31c0d
Signed-off-by: lzelkha at redhat.com <lzelkha at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
M packaging/dbscripts/create_views.sql
4 files changed, 16 insertions(+), 8 deletions(-)

Approvals:
  Oved Ourfali: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/32303
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9d838a19e0496951b9821936bd3af215e3a31c0d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <lzelkha at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list