Change in ovirt-engine[master]: engine: Extract code common for cluster network attach/update

lvernia at redhat.com lvernia at redhat.com
Sun Sep 28 10:56:43 UTC 2014


Lior Vernia has submitted this change and it was merged.

Change subject: engine: Extract code common for cluster network attach/update
......................................................................


engine: Extract code common for cluster network attach/update

Validation is very similar in those two commands, so extracted the
common code to a superclass both extend.

Change-Id: I3869fad7c00313626587ba28f867801795061f69
Signed-off-by: Lior Vernia <lvernia at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkOnClusterCommand.java
3 files changed, 62 insertions(+), 71 deletions(-)

Approvals:
  Alona Kaplan: Looks good to me, approved
  Lior Vernia: Verified



-- 
To view, visit http://gerrit.ovirt.org/32905
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3869fad7c00313626587ba28f867801795061f69
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list