Change in ovirt-engine[ovirt-engine-3.4]: userportal, webadmin: keep proper USB support selection

[oourfali at redhat.com]

Oved Ourfali has submitted this change and it was merged.

Change subject: userportal,webadmin: keep proper USB support selection
......................................................................


userportal,webadmin: keep proper USB support selection

There were 2 problems:
1: the UnitVmModel.initUsbPolicy() did set the USB policy always
   to "disabled".
   Fixed by making sure that if the previously selected still applys than
   select it

2: The UnitVmModel.updateDisplayProtocol() have delegated the selection of the
   old display protocol to behavior.postDisplayTypeItemChanged which is too
   late, because meanwhile the VNC has been selected by
   getDisplayProtocol().setItems() which fired an appropriate event which in
   turn changed the USB support to "disabled"
   Fixed by removing the logic from VmModelBehaviorBase and moved it into the
   updateDisplayProtocol() to make sure the event is fired only when needed.

Change-Id: I7e1b1048784e9d0c289fab13b4d8b9b80afd6cc9
Bug-Url: https://bugzilla.redhat.com/966415
Bug-Url: https://bugzilla.redhat.com/1080144
Bug-Url: https://bugzilla.redhat.com/1147827
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
2 files changed, 27 insertions(+), 53 deletions(-)

Approvals:
  Tomas Jelinek: Verified
  Gilad Chaplik: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/33480
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7e1b1048784e9d0c289fab13b4d8b9b80afd6cc9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server